Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component load pr #554

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Component load pr #554

merged 3 commits into from
Dec 29, 2022

Conversation

Y-Less
Copy link
Collaborator

@Y-Less Y-Less commented Dec 28, 2022

Two small improvements to component loading:

  1. Adds "exclude": to the top level of the JSON so you can explicitly not load certain components. Especially when testing I would frequently have to list all the components and remove one just to load all but one:
{
    "exclude": [ "Vehicles" ]
}
  1. Gives a message when a component listed in "components": doesn't exist:
{
    "components": [ "Checkpoints", "GongZones", "Variables" ]
}

Now gives an error instead of silently failing.

@Y-Less
Copy link
Collaborator Author

Y-Less commented Dec 28, 2022

P.S. I now want to write a GongZones component...

@AmyrAhmady AmyrAhmady merged commit d527a81 into master Dec 29, 2022
@AmyrAhmady AmyrAhmady deleted the component-load-pr branch December 29, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants