Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTWS-649 - Correct Host Property - Update #1 #307

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

gayanW
Copy link
Member

@gayanW gayanW commented Oct 9, 2017

Change to get original host and the port values of the running server.

Talk thread: https://talk.openmrs.org/t/how-to-get-server-details-from-httpservletrequest/13554

Issue: RESTWS-649

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 40.36% when pulling 8bc1b8d on gayanW:RESTWS-649-1 into 799057d on openmrs:master.

@gayanW
Copy link
Member Author

gayanW commented Oct 14, 2017

@dkayiwa
There is a discussion going on about this in here:
https://talk.openmrs.org/t/how-to-get-server-details-from-httpservletrequest/13554

I'll ping you when this is ready to be merged.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 40.367% when pulling 4bd4392 on gayanW:RESTWS-649-1 into 799057d on openmrs:master.

@gayanW
Copy link
Member Author

gayanW commented Oct 14, 2017

@dkayiwa dkayiwa merged commit 762cc0f into openmrs:master Oct 19, 2017
@dkayiwa
Copy link
Member

dkayiwa commented Oct 19, 2017

@gayanW next time, can you use a more meaningful pull request title? ☺️

@gayanW
Copy link
Member Author

gayanW commented Oct 20, 2017

@dkayiwa Sure :) But this is an update for the existing RESTWS-649 PR.

Will do 👍

@dkayiwa
Copy link
Member

dkayiwa commented Oct 20, 2017

That does not still prevent you from giving it a meaningful title. 😊

@gayanW gayanW changed the title RESTWS-649 Update RESTWS-649 Correct Host Property - Update Oct 20, 2017
@gayanW gayanW changed the title RESTWS-649 Correct Host Property - Update RESTWS-649 - Correct Host Property - Update Oct 20, 2017
@gayanW gayanW changed the title RESTWS-649 - Correct Host Property - Update RESTWS-649 - Correct Host Property - Update #1 Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants