Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RESTWS-663 - Fix SwaggerSpecificationCreator#hasSearchHandler(resName) #300

Merged
merged 1 commit into from
Sep 15, 2017
Merged

RESTWS-663 - Fix SwaggerSpecificationCreator#hasSearchHandler(resName) #300

merged 1 commit into from
Sep 15, 2017

Conversation

gayanW
Copy link
Member

@gayanW gayanW commented Sep 7, 2017 •
edited
Loading

  • Fix invalid logic in SwaggerSpecificationCreator#hasSearchHandler(resourceName)
  • Remove undeclared methods
  • Remove unnecessary test case SwaggerSpecificationCreatorTest#swaggerSerializeTest()

Issue: RESTWS-663

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 40.437% when pulling 91607d0 on gayanW:RESTWS-663 into d47bf26 on openmrs:master.

@dkayiwa
Copy link
Member

dkayiwa commented Sep 7, 2017

@gayanW can you always add a link to the ticket for easier navigation?

@gayanW
Copy link
Member Author

gayanW commented Sep 7, 2017 •
edited
Loading

Okay. I will from now on.

@dkayiwa
Copy link
Member

dkayiwa commented Sep 7, 2017

I thought the ticket was only about Invalid logic in hasSearchHandler(resourceName) and nothing more.

gayanW
gayanW commented Sep 7, 2017
View reviewed changes
...n/src/main/java/org/openmrs/module/webservices/docs/swagger/SwaggerSpecificationCreator.java Outdated
private boolean hasSearchHandler(String resourceName) {
for (SearchHandlerDoc doc : searchHandlerDocs) {
if (doc.getResourceURL().contains(resourceName)) {
private boolean hasSearchHandler(String resourceName, String resourceParentName) {
Copy link
Member Author

@gayanW gayanW Sep 7, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here goes the actual changes. getParametersListForSearchHandlers(), and getResourceUrl() were unused. So I removed them.

Copy link
Member

@dkayiwa dkayiwa Sep 7, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind having separate pull requests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gayanW ping 😊

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 40.34% when pulling 4d632b4 on gayanW:RESTWS-663 into d47bf26 on openmrs:master.

@gayanW
RESTWS-663 - Fix SwaggerSpecificationCreator#hasSearchHandler(resName)
f1af8cb 
* Fix invalid logic in SwaggerSpecificationCreator#hasSearchHandler(resourceName)
* Add test case: SwaggerSpecificationCreatorTest#hasSearchHandler()
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 40.34% when pulling f1af8cb on gayanW:RESTWS-663 into d47bf26 on openmrs:master.

@dkayiwa dkayiwa merged commit 4563334 into openmrs:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkayiwa dkayiwa dkayiwa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gayanW @coveralls @dkayiwa