Restws 674 - Include More Test cases for ModuleController1_8 in REST Module #292
Conversation
|
@suthagar23, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pgutkowski, @teleivo and @AdamGrzybkowski to be potential reviewers. |
| } | ||
|
|
||
| @Test | ||
| public void shouldTestDefaultRepresentation() throws Exception { |
There was a problem hiding this comment.
shouldTest is not a good name. Can you think of an alternative?
|
@dkayiwa changed to ShouldGetA() format |
|
|
||
| @Test | ||
| public void shouldGetADefaultRepresentation() throws Exception { | ||
| MockHttpServletRequest req = request(RequestMethod.GET, getURI() + "/" + getUuid()); |
There was a problem hiding this comment.
The name does not still reflect what is being tested. For instance, if the default representation was returned without a uuid or any other expected property, would this test name reflect that?
|
@suthagar23 ping |
|
@dkayiwa Okay, I got your point right now |
|
@suthagar23 the test was fine. My comment was simply for you to change the test name to reflect what is being tested. |
Added some test cases for moduleController1_8 Added some test cases for moduleController1_8 Included test cases for Full, Default, and Ref representations. Added some test cases for moduleController1_8
|
@dkayiwa Is it good for the name? |
|
@suthagar23 i think you already know my response to your question. 😊 |
|
@dkayiwa absolutely 😊 |
Included test cases for Full, Default, and Ref representations.