correct pull request review feedback

openmrs · Oct 24, 2017 · c0bb083 · c0bb083
1 parent c978e25
commit c0bb083
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/.../openmrs/module/webservices/rest/web/v1_0/controller/openmrs1_9/ObsController1_9Test.java b/.../openmrs/module/webservices/rest/web/v1_0/controller/openmrs1_9/ObsController1_9Test.java
@@ -91,10 +91,10 @@ public void searchByEncounter_shouldGetVoidedObsIfIncludeAllIsTrue() throws Exce
 
 		executeDataSet("encounterWithObsGroup1_9.xml");
 
-		String encounterUuid = "62967e68-96bb-11e0-8d6b-9b9415a91465";
+		final String ENCOUNTER_UUID = "62967e68-96bb-11e0-8d6b-9b9415a91465";
 
 		MockHttpServletRequest allNonVoidedObsRequest = newGetRequest(getURI());
-		allNonVoidedObsRequest.addParameter("encounter", encounterUuid);
+		allNonVoidedObsRequest.addParameter("encounter", ENCOUNTER_UUID);
 		MockHttpServletResponse allNonVoidedObsResponse = handle(allNonVoidedObsRequest);
 		List<Object> allNonVoidedObsList = deserialize(allNonVoidedObsResponse).get("results");
 
@@ -105,15 +105,15 @@ public void searchByEncounter_shouldGetVoidedObsIfIncludeAllIsTrue() throws Exce
 		handle(deleteRequest);
 
 		MockHttpServletRequest allObsIncludingVoidedRequest = newGetRequest(getURI());
-		allObsIncludingVoidedRequest.addParameter("encounter", encounterUuid);
+		allObsIncludingVoidedRequest.addParameter("encounter", ENCOUNTER_UUID);
 		allObsIncludingVoidedRequest.addParameter("includeAll", "true");
 		MockHttpServletResponse allObsIncludingVoidedResponse = handle(allObsIncludingVoidedRequest);
 		List<Object> allObsIncludingVoidedList = deserialize(allObsIncludingVoidedResponse).get("results");
 
 		assertEquals(allObsIncludingVoidedList.size(), 6);
 
 		MockHttpServletRequest allNonVoidedObsAfterDeleteRequest = newGetRequest(getURI());
-		allNonVoidedObsAfterDeleteRequest.addParameter("encounter", encounterUuid);
+		allNonVoidedObsAfterDeleteRequest.addParameter("encounter", ENCOUNTER_UUID);
 		MockHttpServletResponse allNonVoidedObsAfterDeleteResponse = handle(allNonVoidedObsAfterDeleteRequest);
 		List<Object> allNonVoidedObsAfterDeleteList = deserialize(allNonVoidedObsAfterDeleteResponse).get("results");