O3-2812: Appointments: Refactoring and Code Cleanup #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -47.8 kB (-2%) Total Size: 2.81 MB
ℹ️ View Unchanged
|
|
Trying to do some commits do some preliminary organize the appointments ESM while not going too overboard. The majority of the hooks in the appointments ESM appear to be in various "use*.tx" files within the "hooks" directory. We might want to standardize this a bit more (it is best practice to have multiple hooks in a "use*.tx" file?) but rather making that decision now, I just try to organize things that seems clearly out of place. I refactored two resources.tx file, "appointments.resouce.ts" and 'appointments-table.ts" which basically consisted of deleting those two files and moving the only hook within them that was used into "hooks/useAppointments" There were a few other resource files with hooks that I found with the code: forms.resource.ts I started to refactor them, but held back, because they were generally well encapsulated: ie, each resource file was only used by components within the same directory as the resource file. (And this may be a better pattern than a bunch of "use*" files in a single directory anyway) I did rename "appointment-table.resource.tx" to "home-appointments.resource.tx" for clarity. Also, I didn't do a holistic check to see if all the other hooks were being used, we likely can continue to remove unused ones, perhaps as part of a larger refactor. Apologies if I've stepped on anyone's work! |
# Conflicts: # packages/esm-appointments-app/src/home-appointments/appointments-list.component.tsx
mogoodrich
commented
Feb 2, 2024
packages/esm-appointments-app/src/appointments/appointments.resources.ts
Show resolved
Hide resolved
mogoodrich
requested review from
denniskigen,
ibacher,
donaldkibet,
mseaton,
cioan and
chibongho
denniskigen
approved these changes
Feb 2, 2024
|
Thanks @mogoodrich! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
Related Issue
Other