(feat) Add configurability to Recently Searched Patients feature #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
force-pushed
the
feat/configurable-recent-search
branch
from
b6b4d5a to
3c456ab
Compare
|
Size Change: +83 kB (+3%) Total Size: 2.89 MB
ℹ️ View Unchanged
|
mogoodrich
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Thanks @denniskigen . I'm not super familiar with this code, so only gave a quick review, but looks good, and your reasoning in the PR is sound as well, thanks!
ibacher
approved these changes
Jan 31, 2024
packages/esm-patient-search-app/src/compact-patient-search/compact-patient-search.component.tsx
Outdated
Show resolved
Hide resolved
denniskigen
force-pushed
the
feat/configurable-recent-search
branch
from
0324255 to
31cc083
Compare
ibacher
approved these changes
Feb 5, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR makes the Recently Searched Patients feature configurable by toggling it on only when the
showRecentlySearchedPatientsconfig property is truthy (it defaults tofalse). This is a precursor to future work aimed at improving the performance of the feature.Presently, looking up 10 recently searched patient records by default when the search box is launched is not ideal from a performance perspective. Making this behaviour configurable means users get the default, performant search experience out of the box, and then implementers can choose to opt into the Recently Searched Patients functionality.
I've also removed use of the lodash
debouncefunction, leveraging theuseDebouncehook instead for debounce functionality to theCompactPatientSearchComponentcomponent. I've also updated theopenmrsand@openmrs/esm-frameworklibraries to enable us to leverage some improvements to the configuration system.Here's a sample config schema that enables the feature:
{ "@openmrs/esm-patient-search-app": { "search": { "showRecentlySearchedPatients": true } } }Screenshots
configurable-recent-patient-search.mp4
Related Issue
None
Other
None