(fix) O3-2693 Appointment Creation Form DatePicker uses incorrect minDate format #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibongho
commented
Jan 4, 2024
...esm-appointments-app/src/appointments/forms/create-edit-form/appointments-form.component.tsx
Show resolved
Hide resolved
|
Size Change: +11 B (0%) Total Size: 2.84 MB ℹ️ View Unchanged
|
|
Based on the available guidance for the maxDate prop, it looks like the maxDate and minDate values default to using the US date format, and that the value depends on whatever the locale prop is set to. |
mogoodrich
reviewed
Jan 4, 2024
| @@ -90,7 +90,7 @@ const AppointmentForm: React.FC<AppointmentFormProps> = ({ appointment, patientU | |||
| ); | |||
|
|
|||
| const appointmentService = services?.find(({ uuid }) => uuid === patientAppointment.serviceUuid); | |||
| const today = dayjs().startOf('day').format(); | |||
| const today = dayjs().startOf('day').format('DD/MM/YYYY'); | |||
There was a problem hiding this comment.
Adding a quick comment without knowing much about this ticket or the broader tickets, which I think are meant to deal with this broadly. but the display format of a date should be customizable by implementation. For our default in O2, we tend to use a format "1-Jan-2024" , which the month specifically implemented as text so that "DD/MM/YYYY" is not misintrepreted as "MM/DD/YYYY" format by US users. But you may already be on top of that... :) Again, I realize this is a quick fix just to get this working again.
There was a problem hiding this comment.
We can directly pass the date object in the maxDate prop, instead of the format, which is more reliable.
CC: @ibacher @denniskigen
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh... yes, if the use of this variable is to populate the maxDate prop, we shouldn't be doing any formatting with it at all, as that will be pretty inherently non-portable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
As of today (2024-01-03) the Appointment creation DatePicker only allows for dates after 2024-04-20
With this change, the minDate defaults correctly to today's date (2024-01-03)
The Carbon documentation is lacking on what format should be accepted for its minDate and maxDate params. From cursory trial-and-error, it seems like the format should follow the
dateFormatpassed in to the DatePicker.https://react.carbondesignsystem.com/?path=/docs/components-datepicker--overview#datepicker-mindate
Screenshots
Related Issue
This is a quick fix for this particular issue, but there are likely other similar problems elsewhere in the code base. A more complete fix should probably involve a standardized DatePicker. See:
https://openmrs.atlassian.net/browse/O3-998
https://openmrs.atlassian.net/browse/O3-1991
Other