-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) service-queues: Fix queue table empty state UI #1452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a follow-up to #1390 which amended the Service Queues dashboard to align more closely with the designs. This PR fixes an additional issue with the queue table where the empty state wasn't being displayed correctly. More specifically, it: - Amends the styling of the queue table empty state to match the designs. - Fixes the positioning of the loading indicator in the queue table toolbar so it's further offset to the right.
Size Change: +5.92 kB (+0.08%) Total Size: 7.28 MB ℹ️ View Unchanged
|
ibacher
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR is a follow-up to #1390 which amended the Service Queues dashboard to align more closely with the designs. This PR fixes an additional issue with the queue table where the empty state wasn't being displayed correctly. More specifically, it:
Screenshots
Before
Empty state UI doesn't have the correct margins and its parent container doesn't have the correct background color
After
Fixed empty state UI
Fixed alignment of inline loader shown when revalidating data
Related Issue
Other