(refactor) Refactor bed management app to match conventions #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR applies a set of changes to the bed management app to match the conventions of the other apps in the O3 ecosystem.
|
Size Change: +811 B (+0.01%) Total Size: 6.66 MB ℹ️ View Unchanged
|
denniskigen
commented
Nov 12, 2024
| bedRow: numberInString, | ||
| bedColumn: numberInString, | ||
| bedType: z.string().refine((value) => value != '', 'Please select a valid bed type'), |
There was a problem hiding this comment.
Reminder to self to translate this string in a follow-up that refactors the schema to incorporate translations.
ibacher
approved these changes
Nov 13, 2024
packages/esm-bed-management-app/src/bed-administration/bed-administration-form.component.tsx
Show resolved
Hide resolved
packages/esm-bed-management-app/src/bed-administration/bed-administration-form.component.tsx
Show resolved
Hide resolved
| "addBedTag": "Create Bed Tag", | ||
| "addBedtype": "Add Bed Type", | ||
| "addBedType": "Create Bed type", | ||
| "addBedTag": "Create bed tag", |
There was a problem hiding this comment.
Something we need to work on: a lot of these case-changes are probably for the best, but I believe Transifex treats them as effectively new strings meaning that these changes invalidate existing translations, even for scenarios where the capitalization is different.
There was a problem hiding this comment.
Yeah. Should we favor enforcing sentence case only for new strings? That seems like a reasonable middle ground to me. Admittedly, I'm the biggest culprit for trying to enforce visual consistency, which, though nice, is probably not the most important concern for translators and users of the system.
There was a problem hiding this comment.
Should we favor enforcing sentence case only for new strings?
I'd be in favour of it. I kind of agree that sentence case looks nicer than "Button To Do The Thing".
chibongho
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR applies a set of changes to the bed management app to match the conventions of the other apps in the O3 ecosystem.
Screenshots
Related Issue
Other