Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-3828: Patient search crashes with Uncaught RangeError #1288

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

chimanwadike
Copy link
Contributor

@chimanwadike chimanwadike commented Aug 20, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes uncaught errors related to search results that include patients with missing dates of birth

Screenshots

Before
image

After
image

Related Issue

https://issues.openmrs.org/browse/O3-3828

Other

@denniskigen denniskigen requested a review from brandones August 20, 2024 10:37
@denniskigen
Copy link
Member

denniskigen commented Aug 20, 2024

Thanks, @chimanwadike. Code LGTM. In what cases would a patient not have a date of birth (actual or estimated)? cc @dkayiwa @ibacher

@ibacher
Copy link
Member

ibacher commented Aug 20, 2024

Birthdate is not technically a required field, though I think that's more a result of not every Person being a Patient.

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@denniskigen denniskigen merged commit 8fecf37 into openmrs:main Aug 20, 2024
6 checks passed
@denniskigen denniskigen mentioned this pull request Aug 29, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants