(feat) O3-3243: Ward App - add configurable extension to include patient identifier #1197
Conversation
|
Hi @chibongho , @mseaton , @mogoodrich , @brandones , @vasharma05 , @usamaidrsk.Please share your feedback. |
chibongho
requested review from
chibongho,
mseaton,
mogoodrich,
brandones and
vasharma05
packages/esm-ward-app/src/ward-patient-card/row-elements/ward-patient-identifier.tsx
Outdated
Show resolved
Hide resolved
packages/esm-ward-app/src/ward-patient-card/row-elements/ward-patient-identifier.tsx
Outdated
Show resolved
Hide resolved
| export const defaultPatientCardElementConfig: PatientCardElementConfig = { | ||
| addressFields: defaultPatientAddressFields, | ||
| identifierTypeUuid: defaultIdentifierTypeUuid, |
There was a problem hiding this comment.
I'd just make this set to null by default, and have the element use the preferred patient identifier by default. (See comment below)
There was a problem hiding this comment.
Agreed. Without a specific identifierType configured, it should not default to restrict to a particular type
| export const defaultPatientCardElementConfig: PatientCardElementConfig = { | ||
| addressFields: defaultPatientAddressFields, | ||
| identifierTypeUuid: defaultIdentifierTypeUuid, |
There was a problem hiding this comment.
Agreed. Without a specific identifierType configured, it should not default to restrict to a particular type
packages/esm-ward-app/src/ward-patient-card/row-elements/ward-patient-identifier.tsx
Outdated
Show resolved
Hide resolved
packages/esm-ward-app/src/ward-patient-card/row-elements/ward-patient-identifier.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| return ( | ||
| <div> | ||
| <Tag>{`${patientIdentifier?.identifierType.name}:`}</Tag> |
There was a problem hiding this comment.
I would not assume that we always want to display the identifier type name, and even if we did want to always have a label, identifierType name may not be appropriate as it is not localized.
We will want to do something like what @chibongho is doing with the obs element, where one can configure a custom label, or no label, or choose (via configuration) to use the type as the label.
There was a problem hiding this comment.
hi @mseaton , i have made the changes for displaying patient identifier name with the value specified in config. Please let me know for any other changes. Thank you.
kb019
force-pushed
the
feat/patientIdentifier
branch
2 times, most recently
from
46714ea to
d5e78f3
Compare
kb019
force-pushed
the
feat/patientIdentifier
branch
from
d5e78f3 to
d525e31
Compare
| import { useTranslation } from 'react-i18next'; | ||
|
|
||
| const identifierCompareFunction = (pi1: PatientIdentifier, pi2: PatientIdentifier) => { | ||
| //check if preferred is set to true in any of patient identifier, if preferred is true |
There was a problem hiding this comment.
comment on the intent instead of what the code is doing line-by-line. Something like "sort the identifiers by preferred first, then (dateChanged or dateCreated) in descending order."
|
@chibongho @kb019 What's the next step on this? |
Hi @brandones , sorry for late reply.I am not sure what are the next steps. I will defer that to @chibongho . But i have resolved the conflicts. Thanks. |
Requirements
Summary
Ability to incoporate patient-identifier into the patient card header.If multiple identifiers are found for the same identifier type,then the once which has preffered:true takes precedence,else if both the identifiers have same precedence the one with the most recent date takes precedence.
Related Issue
https://openmrs.atlassian.net/browse/O3-3243