(fix) O3-3398: Combine the translation for Create New Patient/ Edit Patient #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasharma05
changed the title
|
Size Change: -18 B (0%) Total Size: 3.47 MB ℹ️ View Unchanged
|
denniskigen
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Thanks for this, @vasharma05. I've left some suggestions about casing and a change to the Edit patient translation string.
| @@ -15,7 +15,7 @@ | |||
| "configure": "Configure", | |||
| "configureIdentifiers": "Configure identifiers", | |||
| "contactSection": "Contact Details", | |||
| "createNew": "Create New", | |||
| "createNewPatient": "Create New Patient", | |||
There was a problem hiding this comment.
Suggested change
| "createNewPatient": "Create New Patient", | |
| "createNewPatient": "Create new patient", |
Prefer sentence-case. See https://zpl.io/VDNg9BO and https://carbondesignsystem.com/guidelines/content/writing-style#capitalization.
| "editIdentifierTooltip": "Edit", | ||
| "editPatient": "Edit Patient", |
There was a problem hiding this comment.
Suggested change
| "editPatient": "Edit Patient", | |
| "editPatient": "Edit patient", |
| <h4> | ||
| {inEditMode ? t('edit', 'Edit') : t('createNew', 'Create New')} {t('patient', 'Patient')} | ||
| </h4> | ||
| <h4>{inEditMode ? t('editPatient', 'Edit Patient') : t('createNewPatient', 'Create New Patient')}</h4> |
There was a problem hiding this comment.
Suggested change
| <h4>{inEditMode ? t('editPatient', 'Edit Patient') : t('createNewPatient', 'Create New Patient')}</h4> | |
| <h4>{inEditMode ? t('editPatientDetails', 'Edit patient details') : t('createNewPatient', 'Create new patient')}</h4> |
|
Changes done @denniskigen! |
denniskigen
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Create New Patient translation was broken into 2 words: Create New and Patient
The same was the case for Edit Patient: Edit and Patient
Screenshots
None
Related Issue
https://issues.openmrs.org/browse/O3-3398
Other