O3-3030 service queues: fix NPE in mapVisitQueueEntryProperties #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibongho
requested review from
mseaton,
mogoodrich,
ojwanganto,
makombe and
donaldkibet
|
Size Change: +179 B (0%) Total Size: 3.12 MB ℹ️ View Unchanged
|
mseaton
reviewed
Apr 5, 2024
There was a problem hiding this comment.
@chibongho - this isn't the fix I was expecting. Are these encounters not needed / used anywhere?
|
@chibongho Thanks for the fix. I think there is also another place where |
|
you can as well do a custom |
|
I don't see that field being used anywhere. If we expect to need it later I can change this to fix it via the |
@chibongho please check here |
|
and here as well some of the properties we are mapping are not being returned. Thanks |
|
ok, I changed the @makombe Where is the |
denniskigen
previously approved these changes
Apr 5, 2024
denniskigen
dismissed
their stale review
Sorry, I hadn't read the rest of the comments.
makombe
approved these changes
Apr 7, 2024
senthil-athiban
pushed a commit
to senthil-athiban/openmrs-esm-patient-management
that referenced
this pull request
Apr 15, 2024
…mrs#1085) * O3-3030 service queues: fix NPE in mapVisitQueueEntryProperties * change default rep string for queue entries to include visit encounters --------- Co-authored-by: Makombe Kennedy <[email protected]>
denniskigen
added a commit
that referenced
this pull request
Aug 8, 2024
…e left empty (#1182) * (fix) fix typo on recurring appointment label (#1047) * (fix) service queues - make edit queue entry modal body scrollable if content is too long (#1042) * (fix) O3-2471 recommended visit type tab should only show if configured to do so (#1045) * (fix) service queues - unescape queue name when passed into t() (#1043) Co-authored-by: Jayasanka Weerasinghe <[email protected]> * (refactor) O3-2891: Refactor Patient Appointments ESM into Appointments ESM (#1048) * (feat) re-use upcomming appointment work to mark appointments as `Checked In` (#1050) * (chore) Update translations from Transifex (#1011) Co-authored-by: OpenMRS Bot <[email protected]> Co-authored-by: Mark Goodrich <[email protected]> * (feat) use configured identifier type on appointment table (#1054) * (fix) add `@openmrs/esm-patient-common-lib` as peer dependency and register appointment workspace correctly (#1053) * (fix): Enhanced Tablet View: Service Queues Metrics Header Overhaul (#1046) * (fix): Tablet-UI. Making Tablet Service-queues metrics header responsive on tablet mode Signed-off-by: Joshua Murithi <[email protected]> * Fixup --------- Signed-off-by: Joshua Murithi <[email protected]> Co-authored-by: Dennis Kigen <[email protected]> * (chore) Update translations from Transifex (#1055) Co-authored-by: OpenMRS Bot <[email protected]> Co-authored-by: Mark Goodrich <[email protected]> * Enhanced Monthly Calendar UI for Appointment Scheduler (#1049) * Enhanced Monthly Calendar UI for Appointment Scheduler * clicking on a day from within the month to change the appointment date * Localized days in weeks * Removed weekly calendar view on appointment scheduler --------- Co-authored-by: Donald Kibet <[email protected]> * (BREAKING) O3-2748 service queues - add ability to undo transitions and void queue entries (#1052) * (BREAKGING) O3-2748 service queues - add ability to undo transitions and void queue entries * add tests * minor wording fixup * remove unused imports * change undo transition route per update in backend PR * address PR comments * (chore) O3-2989 service queues - refactor <PatientSearch> to not have things unrelated to patient serach (#1058) * (feat) O3-2892: Add Patient-Centric View within the Appointments App (#1057) * O3-2788 (fix) appointments table should correctly search by patient name or identifier (#1067) * (fix) O3-3009 Appointment form should limit location to those tagged as 'Appointment Location' (#1066) * (fix) O3-3013 Appointment Form should validate invalid time values (#1069) * (fix) O3-3013 appointment time validation should match entire string (#1073) * (feature) O3-2930: Add date of birth to patient details in Appointments Module Co-authored-by: Mark Goodrich <[email protected]> * (feat) O3-3025: Add validation in change status modal for service queues (#1076) * (feat) O3-3025: Add validation in change status modal for service queues * (test) updated test to reflect changes * (fix) O3-2748 service queue - fix NPE in undo transition dialog (#1077) * (fix) Fix queue filtering by location (#1078) * (chore) Separate linting and formatting concerns (#1080) * (feat) O3-3030 - make new queue table support creating new queue entry (#1079) * (feat) O3-3030 - make new queue table support creating new queue entry * fix metrics * address PR comment * (fix):O3-3039-Fix Incorrect Client Selection Issue When Navigating Pages in Queue Table (#1082) * (refactor) O3-3012: Switch registering appointments form workspace ba… (#1068) * (fix) Fix error for undifined attribute type (#1083) * (test) O3-3005: Add E2E test for registering an unknown patient (#1070) Co-authored-by: Dennis Kigen <[email protected]> * (fix) Handle null start date on patient list details (#1081) * Handle null start date on list details * Removed unnecessary optional chaining --------- Co-authored-by: Dennis Kigen <[email protected]> * (chore) Update translations from Transifex (#1059) Co-authored-by: OpenMRS Bot <[email protected]> Co-authored-by: Ian <[email protected]> * (refactor) O3-2685: Inconsistent / Duplicated Appointments List UI between Home App and Appointments App (#1084) * (chore) Fix Prettier glob patterns * O3-3030 service queues: fix NPE in mapVisitQueueEntryProperties (#1085) * O3-3030 service queues: fix NPE in mapVisitQueueEntryProperties * change default rep string for queue entries to include visit encounters --------- Co-authored-by: Makombe Kennedy <[email protected]> * (test) Remove mock implementations of usePagination (#1088) * (test) Remove mock implementations of usePagination * Fixup * (chore) Bump playwright (#1090) * O3-3043 - (feat) service queues - add new view of queue entries showin… (#1086) * O3-3043 - (feat) service queues - add new view of queue entries showing one table per status * move queue-table-for-all-statuses into view/ * (chore) Flag rules-of-hooks lint violations (#1091) * (chore) Flag rules-of-hooks lint violations * Fix e2e tests * (chore) Update translations from Transifex (#1087) Co-authored-by: OpenMRS Bot <[email protected]> Co-authored-by: Ian <[email protected]> * (feat) O3-3063: UI tweaks for the Today's appointments widget (#1092) * (feat) UI tweaks for the Today's appointments widget * Appointments dashboard fixes * (fix) O3-3063: Fix appointments table empty state text (#1094) * (feat) O3:3063: Appointments dashboard UI tweaks (#1096) * (fix) Fix appointment metrics error state * Enhanced relationship display logic to differentiate 'Patient' roles (#1089) * (fix): improve client side form validation * (fix): error validation * Fixup --------- Signed-off-by: Joshua Murithi <[email protected]> Co-authored-by: Donald Kibet <[email protected]> Co-authored-by: chibongho <[email protected]> Co-authored-by: Michael Seaton <[email protected]> Co-authored-by: Jayasanka Weerasinghe <[email protected]> Co-authored-by: Mark Goodrich <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: OpenMRS Bot <[email protected]> Co-authored-by: Joshua Murithi <[email protected]> Co-authored-by: Dennis Kigen <[email protected]> Co-authored-by: Gabriel Mbatha Ngao <[email protected]> Co-authored-by: sparsh989 <[email protected]> Co-authored-by: Makombe Kennedy <[email protected]> Co-authored-by: Daud Kakumirizi <[email protected]> Co-authored-by: Pedro Sousa - ICRC <[email protected]> Co-authored-by: Ian <[email protected]> Co-authored-by: Piyush Mishra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Previous commit introduce an NPE in
mapVisitQueueEntryProperties. Fixing it by removing an unused field inMappedVisitQeueEntry.Screenshots
Related Issue
Other