(feat) Improvements to the order basket #2170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -178 kB (-1.09%) Total Size: 16.1 MB
ℹ️ View Unchanged
|
|
Thanks @vasharma05 from watching the video attached, when you chose to modify a drug order the workspace title read The build is failing, if you could checkout why. |
|
Forgot to update the video, as per this commit, the workspace title will be set according to the order type I am figuring out why a unit test is failing, hence the build failing |
|
Updated the video in the PR description @usamaidrsk |
|
Can we unwind the features in this PR into a few different PRs. Not all of them, I think, are well-defined features but some of them are. E.g., 3-7 are, I think, unobjectionable. I have serious reservations about 1 being at all functionally functionally useful in a real-world scenario (it's more likely that we want this to be configurable on a per-test basis). I have fewer issues with 2, but I think that's enough of a change to deserve it's own PR. While this isn't a massive PR in terms of code, it is grouping a lot of only semi-related concerns. |
|
Yes @ibacher, I myself am working for creating more basic PRs out of it |
|
This PR is segregated into multiple smaller PRs, hence closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR makes the following changes to the order basket:
Reference numberfield in the order formen.jsonfor error messages in the order formON_SCHEDULED_DATE, a date field should be rendered to select respective date.Screenshots
Screen.Recording.2025-01-09.at.19.21.59.mov
Related Issue
Other