(refactor) Use concept resource for conditions search #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently, we are using the [conceptsearch resource](https://github.com/openmrs/openmrs-esm-patient-chart/blob/main/packages/esm-patient-conditions-app/src/conditions/conditions.resource.ts#L109) to do a lookup for conditions in the Conditions form. This is different from what we do in the Visit note form’s diagnosis search fields where we use the [concept resource](https://github.com/openmrs/openmrs-esm-patient-chart/blob/main/packages/esm-patient-notes-app/src/notes/visit-notes.resource.ts#L106) with a fuzzy search. One undesired side effect of using conceptsearch as we’re currently using it is that cross-locale searches don’t work. If the locale is set to fr for example, you can only search using the french names for a condition. So searching for malaria in the Condition search field won’t return anything, you’d have to search for paludisme. We should use the concept resource with a fuzzy search for the Conditions form as well for a consistent search experience.
|
Size Change: +40 B (0%) Total Size: 16 MB ℹ️ View Unchanged
|
Moves the search results rendering logic from an IIFE to a dedicated SearchResults component. This improves code readability and maintainability by better separating concerns. It also fixes a rendering issue where clearing the search field would lead to the last search result being displayed.
ibacher
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Presently, we are using the conceptsearch resource to do a lookup for conditions in the Conditions form. This is different from what we do in the Visit note form’s diagnosis search fields where we use the concept resource with a fuzzy search.
One undesired side effect of using conceptsearch as we’re currently using it is that cross-locale searches don’t work. If the locale is set to fr for example, you can only search using the french names for a condition. So searching for malaria in the Condition search field won’t return anything, you’d have to search for paludisme.
We should use the concept resource with a fuzzy search for the Conditions form as well for a consistent search experience.
Screenshots
conditions-search-refactor.mp4
Rendering bug when clearing the input
condition-issue.mp4
Fix
conditions-rendering-issue-fix.mp4
Related Issue
Other