-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor) Use react hook form's isSubmitting state #2141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors submit state management logic in several forms to use react hook form's `isSubmitting` state. React hook form's [formState](https://react-hook-form.com/docs/useform/formstate#formState.isSubmitting) API provides a built-in `isSubmitting` state that can be used to manage the submit state of a form. This is a more reliable and easier to manage approach than using a custom state variable.
Size Change: -139 B (0%) Total Size: 16 MB ℹ️ View Unchanged
|
ibacher
approved these changes
Dec 9, 2024
This was referenced Dec 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Refactors submit state management logic in several forms to use react hook form's
isSubmitting
state. React hook form's formState API provides a built-inisSubmitting
state that can be used to manage the submit state of a form. This is a more reliable and easier to manage approach than using a custom state variable.Screenshots
Related Issue
Other