Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-4040: Add delete ability to program enrollments #2133
base: main
Are you sure you want to change the base?
(feat) O3-4040: Add delete ability to program enrollments #2133
Changes from 64 commits
cbbff83
b81e251
80c62ed
14e044a
2ede494
a66f460
a6684fa
576c2ad
ac33454
8ddee66
4ee37bb
a683be1
470f200
5ea6b91
f4b550f
3236b0d
7ab780f
de252d4
9d444b6
49e52d3
847261c
4352fe8
17a7079
7840ee8
9869444
421d61f
f871f46
cc0cfb0
6762df0
db768d8
7223a13
04842e4
dfe5356
05f8b3d
1f17b78
3a64344
a0bc18a
bdae7c6
b1a153b
17c07ea
70f7a04
f1498e9
fb93d08
9dd408f
0cacc23
06413b5
c7b7962
3b7127e
1654142
6f98879
92d545c
26d2a49
1876c76
53bbbe2
6da388d
529b542
4dd1699
fbc226a
5262ad8
4990847
f9db4ff
bd588b9
4363f81
cf60eeb
902454b
be6cfb9
d71d7f3
72826b1
7dad9e1
218b024
e7db186
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the styles for that would be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and all it's related files should be renamed to
programs-action-menu
for consistency.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can wrap this in a
useCallback
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And then the associated styles would look something like this:
This will make your UI visually consistent with other flows like the Conditions edit experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
OverflowMenu
should be left-aligned so it's content does not flow over the width of the datatable. Additionally, we should remove thename
prop as it's not a known prop of the OverflowMenu component.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the correct name for this component and file should be
ProgramsActionMenu
andprograms-action-menu.component
respectively.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cds--table-column-menu
isn't strictly necessary here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is here to ensure the OverflowMenu takes up the appropriate amount of space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add this to the
ProgramsOverview
component as well for consistency.