-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-4208: Add Configuration to Display Lab Reference Number Input on the Test Order Form #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usamaidrsk
changed the title
(feat) O3-4208: add config to show lab reference number input
(feat) O3-4208: Add Configuration to Display Lab Reference Number Input on the Test Order Form
Nov 19, 2024
Size Change: +88 B (0%) Total Size: 15.9 MB ℹ️ View Unchanged
|
denniskigen
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a couple suggestions about naming.
Co-authored-by: Dennis Kigen <[email protected]>
Co-authored-by: Dennis Kigen <[email protected]>
denniskigen
reviewed
Nov 21, 2024
packages/esm-patient-tests-app/src/lab-orders/add-lab-order/lab-order-form.component.tsx
Outdated
Show resolved
Hide resolved
usamaidrsk
added a commit
that referenced
this pull request
Nov 21, 2024
…ut on the Test Order Form (#2111) * feat: add config to show lab reference number input * change to showLabReferenceNumberField Co-authored-by: Dennis Kigen <[email protected]> * update config description Co-authored-by: Dennis Kigen <[email protected]> * fix: fix build --------- Co-authored-by: Dennis Kigen <[email protected]>
3 tasks
usamaidrsk
added a commit
that referenced
this pull request
Dec 3, 2024
) * (feat) add price and stock details on order items * (chore) translations * mock requests * (fix): reset addLabOrderWorkspace width * (feat) update design * (chore) extract translations * (fix) fix component styles * (fix) remove price and stock on labsa and drugs search items * (fix) extract translations * (fix) memoize slot state * (fix) memoize price data * (fix) memoize price data * (fix) fix import icons from framework * feat: add backed dependencies * chore: add unit tests * address pr reviews * check if needed modules are installed * address pr reviews * fix tests * fix tests * (fix) address reviews, rename useIsBackendModuleInstalled.tsx to useAreBackendModuleInstalled.tsx * fix: remover unnecessary clear mocks * (chore) Bump RFE version (#2110) * (chore) Bump RFE version for QA * bump rfe to the latest version --------- Co-authored-by: Usama Idriss Kakumba <[email protected]> * (chore) Bump form engine version (#2112) Bump form engine version * (chore) Update translations from Transifex (#2108) Co-authored-by: OpenMRS Bot <[email protected]> * (feat) O3-4208: Add Configuration to Display Lab Reference Number Input on the Test Order Form (#2111) * feat: add config to show lab reference number input * change to showLabReferenceNumberField Co-authored-by: Dennis Kigen <[email protected]> * update config description Co-authored-by: Dennis Kigen <[email protected]> * fix: fix build --------- Co-authored-by: Dennis Kigen <[email protected]> * add optionalBackendDependencies --------- Co-authored-by: Pius Rubangakene <[email protected]> Co-authored-by: Samuel Male <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: OpenMRS Bot <[email protected]> Co-authored-by: Dennis Kigen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR Introduces a configuration option to enable or disable the lab reference number input field on the test order form.
showLabReferenceNumberInput
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4208
Other