-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(test) O3-4156: Add tests for grouped timeline component #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 15.9 MB ℹ️ View Unchanged
|
denniskigen
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @CynthiaKamau. I've left some suggestions.
packages/esm-patient-tests-app/src/test-results/grouped-timeline/grouped-timeline.test.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-tests-app/src/test-results/grouped-timeline/grouped-timeline.test.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-tests-app/src/test-results/grouped-timeline/grouped-timeline.test.tsx
Outdated
Show resolved
Hide resolved
denniskigen
changed the title
(tests) O3-4156 Add tests for grouped timeline component
(test) O3-4156: Add tests for grouped timeline component
Nov 7, 2024
denniskigen
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @CynthiaKamau!
senthil-athiban
pushed a commit
to senthil-athiban/openmrs-esm-patient-chart
that referenced
this pull request
Nov 19, 2024
* (tests) O3-4156 Add tests for grouped timeline component * (tests) O3-4156 Add tests for grouped timeline component * Add some more coverage --------- Co-authored-by: Dennis Kigen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Adds test coverage for the
GroupedTimeline
component in the Results Viewer.Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4156
Other