(feat) O3-4166 - add option to hide links in vitals header #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibongho
requested review from
mseaton,
mogoodrich,
denniskigen,
donaldkibet and
ibacher
|
Size Change: +34 B (0%) Total Size: 15.9 MB ℹ️ View Unchanged
|
denniskigen
reviewed
Nov 6, 2024
|
Added tests. I am not sure why, but I couldn't get the test to query the "Record Vitals" button with |
|
I’ll have a look. Thanks, @chibongho! |
|
It's because that button text matches two elements:
Using a regex match should get it to match the exact text: expect(screen.getByRole('button', { name: /^record vitals$/i })).toBeInTheDocument();I've pushed a commit fixing it here. |
3 tasks
senthil-athiban
pushed a commit
to senthil-athiban/openmrs-esm-patient-chart
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
https://openmrs.atlassian.net/browse/O3-4166
We have a use case to include the vitals header in the ward app, and have it not display any links to the O3 patient chart or launch the record vitals workspace.
I thought about adding a config option in the vitals app to configure custom links and use
<ConfigurableLink>, but that doesn't let us representlaunchWorkspaceactions.Screenshots
Related Issue
Other