(fix) Pass patient as a prop where-ever possible in the chart #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1.77 MB (-10.71%) 👏 Total Size: 14.8 MB
ℹ️ View Unchanged
|
denniskigen
reviewed
Sep 17, 2024
| @@ -58,7 +57,7 @@ const CapturePhoto: React.FC<CapturePhotoProps> = ({ initialState, onCapturePhot | |||
| className={styles.editButton} | |||
| kind="ghost" | |||
| onClick={showCam} | |||
| renderIcon={(props) => <Edit {...props} />} | |||
| renderIcon={(props: Partial<Parameters<typeof EditIcon>[0]>) => <EditIcon {...props} />} | |||
There was a problem hiding this comment.
Comparing apples to apples, but maybe this signature could be simplified to:
Suggested change
| renderIcon={(props: Partial<Parameters<typeof EditIcon>[0]>) => <EditIcon {...props} />} | |
| renderIcon={(props: React.ComponentProps<typeof EditIcon>) => <EditIcon {...props} />} |
There was a problem hiding this comment.
Actually, no. That's way more explicit, even if not necessarily shorter. Let me fix that.
|
In retrospect, I probably should've done the icons in a separate PR, but here we hare. |
|
Let's see how this pans out in the refapp! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
The bulk of the changes here focus on ensuring that we are using the
fhir.Patientobject from the Patient Chart state wherever possible, meaning that most components do not require a separate call tousePatient(). I've re-written a few hooks to adjust for this (i.e.,usePatientDeceasedStatus()is basically just a hook that gets a boolean result based on the patient).There are a few miscellaneous changes:
Screenshots
Related Issue
Other
Unchanged for now are most workspaces and panels.
This removes about 7 requests when loading the chart summary and 1-per-row when loading the result viewer, so the chart should feel snappier.
I'm unsure about some of the action buttons functioning when the banner is rendered in the search results, since this uses dummied FHIR objects. However, I'm of the view that actions in the search results are bad UX and should be removed.