(fix) O3-3545: Remove duplicate lab tests in lab order workspace #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +43 B (0%) Total Size: 11.1 MB ℹ️ View Unchanged
|
denniskigen
changed the title
|
Excellent. Thanks, @ibacher! |
denniskigen
approved these changes
Jul 15, 2024
denniskigen
reviewed
Jul 15, 2024
| <TestTypeSearchResultItem key={index} openOrderForm={openOrderForm} t={t} testType={testType} /> | ||
| {filteredTestTypes.map((testType) => ( | ||
| <TestTypeSearchResultItem | ||
| key={testType.conceptUuid} |
There was a problem hiding this comment.
Now that we're reasonably certain that the conceptUuids are unique, we can use them as keys in the test type search results list.
| @@ -52,7 +52,9 @@ describe('useTestTypes is configurable', () => { | |||
| orders: { labOrderableConcepts: [] }, | |||
| }); | |||
| const { result } = renderHook(() => useTestTypes()); | |||
| expect(mockOpenrsFetch).toHaveBeenCalledWith('/ws/rest/v1/concept?class=Test'); | |||
| expect(mockOpenrsFetch).toHaveBeenCalledWith( | |||
| '/ws/rest/v1/concept?class=Test?v=custom:(display,uuid,setMembers:(display,uuid,setMembers:(display,uuid)))', | |||
arodidev
pushed a commit
to arodidev/openmrs-esm-patient-chart
that referenced
this pull request
Jul 16, 2024
…nmrs#1909) * (test) Fix flaky behaviour in Programs and Conditions form tests * Try something else * Fixup (test) Fix yet more flakiness in ConditionsForm tests (chore) Bump React Form Engine library (openmrs#1913) (chore) Bump RFE lib (chore) Update translations from Transifex (openmrs#1906) Co-authored-by: OpenMRS Bot <[email protected]> (fix) O3-2995: Allow empty quantity to dispense and prescription refills in Drug Order Form (openmrs#1754) Co-authored-by: Dennis Kigen <[email protected]> (fix) O3-3543: Fix test types search in the lab order workspace (openmrs#1910) * added fragment * Other useful mods * Factor out filtering from useTestTypes hook * Review feedback --------- Co-authored-by: Dennis Kigen <[email protected]> (fix) O3-3545: Remove duplicate lab tests in lab order workspace (openmrs#1916) * (fix) O3-3545: Remove duplicate copies of labs * Fixup --------- Co-authored-by: Dennis Kigen <[email protected]> Bump loader-utils from 2.0.2 to 2.0.4 (openmrs#1918) Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md) - [Commits](webpack/loader-utils@v2.0.2...v2.0.4) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (feat) Replace fuzzy search with simple filter for test types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Removes duplicate lab tests. See #1910 for context.
Screenshots
Related Issue
Other