(feat) O3-2859: Change Patient Appointments to use shared appointments form #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Form from Appointments ESM
… Form from Appointments ESM
… Form from Appointments ESM
|
Size Change: -227 kB (-2%) Total Size: 10.6 MB
ℹ️ View Unchanged
|
|
See: https://openmrs.atlassian.net/browse/O3-2859 This should be merged in conjunction with: |
3 tasks
mogoodrich
commented
Feb 16, 2024
| @@ -63,57 +58,7 @@ export function useAppointments(patientUuid: string, startDate: string, abortCon | |||
| }; | |||
| } | |||
|
|
|||
| export function useAppointmentService() { | |||
There was a problem hiding this comment.
All this stuff and the files deleted above are files that were previously copied to esm-appointments-app
| @@ -1,47 +1 @@ | |||
| export const datePickerPlaceHolder = 'dd/mm/yyyy'; | |||
There was a problem hiding this comment.
More code that is no longer used
| () => import('./appointments/appointments-form/appointments-form.component'), | ||
| options, | ||
| ); | ||
|
|
There was a problem hiding this comment.
this now gets created in the esm-appointments-app
| { | ||
| "name": "appointments-form-workspace", | ||
| "component": "appointmentsFormWorkspace" | ||
| }, |
There was a problem hiding this comment.
this now gets set up in the esm-appointments-app
There was a problem hiding this comment.
Hi @mogoodrich!
Can you please register workspace with registerWorkspace instead of routes.json in the esm-appointments-app index.ts?
Thanks!
There was a problem hiding this comment.
A bit tangential. I was under the impression that the workspace stuff only works in esm-patient-chart given the nowhere in esm-patient-management do we use registerWorkspace and launchPatientWorkspace as of now. I would be really happy if that's not the case.
(The above probably still works for patient chart regardless)
There was a problem hiding this comment.
The availability of this functionality is the result having the patient-common-lib as a peerDependency of the module (which is what implements those functions). The only advantage the patient chart has is that it will implicitly depend on the latest version.
| @@ -4,62 +4,30 @@ | |||
| "appointmentCancelError": "Error cancelling appointment", | |||
There was a problem hiding this comment.
so these are (assumedly) all translations that no longer used in the patient-chart... however, assumedly most/all of them have been added to the patient management app... do we have a best practice/strategy, to copy above the translations from one to the other?
There was a problem hiding this comment.
Nothing that isn't "manually copy them" yet. Open to suggestions though!
| setIsSubmitting(true); | ||
|
|
||
| cancelAppointment('Cancelled', appointmentUuid, abortController) |
There was a problem hiding this comment.
unused controller that lint pointed out that I removed
mogoodrich
requested review from
denniskigen,
ibacher,
chibongho and
mseaton
ibacher
changed the title
ibacher
approved these changes
Feb 20, 2024
ojwanganto
approved these changes
Feb 20, 2024
|
Thanks @ibacher @chibongho and @ojwanganto , merging this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Form from Appointments ESM
Requirements
Summary
Screenshots
Related Issue
Other