Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-2400: Fix drag-and-drop logic in the interactive builder #333

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

senthil-athiban
Copy link
Contributor

@senthil-athiban senthil-athiban commented Jul 23, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR addresses the issue of optimally dragging and dropping questions from the source to the destination.

Screenshots

after.mov

Related Issue

https://openmrs.atlassian.net/browse/O3-2400

Other

@senthil-athiban senthil-athiban changed the title (fix) O3-2400 : fix the dnd destination (fix) O3-2400 : Optimize Drag and Drop Functionality for Questions Jul 23, 2024
@denniskigen
Copy link
Member

denniskigen commented Jul 23, 2024

Thanks for fixing this, @senthil-athiban. I've pushed a follow-up commit with some enhancements to improve the drag-and-drop experience:

  • To prevent tooltip collisions when dragging a question over another, the IconButton tooltips are now hidden for 6 seconds.
  • The tooltip text has been changed from 'Reorder question' to 'Drag to reorder' for more clarity.
  • The border colour and size of the Droppable container have been updated to make the drag-and-drop effect more prominent.
  • The dragged question now casts a more pronounced box shadow to provide stronger visual separation from other questions.
  • I've applied a subtle scale transform to the dragged question to enhance the visual effect further.
subtle-tweaks.mp4

Any concerns with the changes?

@denniskigen denniskigen changed the title (fix) O3-2400 : Optimize Drag and Drop Functionality for Questions (fix) O3-2400: Fix drag-and-drop logic in the interactive builder Jul 23, 2024
@senthil-athiban
Copy link
Contributor Author

senthil-athiban commented Jul 23, 2024

No Concerns @denniskigen , LGTM!

Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @senthil-athiban , very great work

@denniskigen denniskigen merged commit b014e19 into openmrs:main Jul 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants