Access method #76
Access method #76
Conversation
provider/README.md
Outdated
| @@ -95,6 +95,7 @@ Data: `{ "trips": [] }`, an array of objects with the following structure | |||
| | `trip_duration` | Integer | Required | Time, in Seconds | | |||
| | `trip_distance` | Integer | Required | Trip Distance, in Meters | | |||
| | `route` | Route | Required | See detail below | | |||
| | `access_method` | Enum | Required | How the user gained access to the vehicle | | |||
There was a problem hiding this comment.
Can you link to #access-methods here like we do for the other enum fields/tables?
Otherwise this looks great, and agreed it is a useful datapoint to have.
|
@mattwigway can you take a look at @thekaveman's comments and we can hopefully merge soon. |
|
Sorry, this dropped off my radar - I'll address tomorrow.
…On Mon, Oct 1, 2018, 10:19 AM Hunter Owens ***@***.***> wrote:
@mattwigway <https://github.com/mattwigway> can you take a look at
@thekaveman <https://github.com/thekaveman>'s comments and we can
hopefully merge soon.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAimrlyJlj0MS_7c4m-nQ9R7h55IKGXXks5ugk6RgaJpZM4WqdHT>
.
|
|
@thekaveman @hunterowens done! Let me know if you need any more changes. |
|
@mattwigway aplogies, we had to change the base branch from |
provider/README.md
Outdated
| @@ -125,6 +125,7 @@ Response: See the [`trips` schema][trips-schema] for the expected format. | |||
| | `trip_duration` | Integer | Required | Time, in Seconds | | |||
| | `trip_distance` | Integer | Required | Trip Distance, in Meters | | |||
| | `route` | GeoJSON `FeatureCollection` | Required | See [Routes](#routes) detail below | | |||
| | `access_method` | Enum | Required | Array of [access methods](#access-methods): how the user gained access to the vehicle | | |||
There was a problem hiding this comment.
Why would there be a multiple access methods for a single trip? (Thinking comments should just say "One of access method...")
|
I merged dev into my branch, solved the conflicts, and addressed @oderby's comment that there should be a single access method per trip (typo on my part). |
|
this pull request needs to update JSONSchema as well. |
|
@hunterowens @thekaveman still a thing? |
|
yeah, let me move the milestone on this. I think there was a similar PR from @cttengsfmta as well that we should get into |
|
moving to 0.4.1./ |
|
|
schnuerle
added
the
privacy
|
Closing this in favor of #569. |
Add an
access_methodto the trips file which details how a user unlocked a vehicle (see #71). I included all the ways I have ever unlocked a shared vehicle, as well as a few I've heard talked about (cash, call center, etc).This will be particularly useful for understanding the use of pilots that allow people to access dockless mobility without smartphones.