-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Geography API from the Policy API #499
Extract Geography API from the Policy API #499
Conversation
…tion/release-1.0.0 Release 1.0.0 - Tech Council Review
From the Working Group call today. Slides from today.
|
# Conflicts: # README.md
geography/README.md
Outdated
} | ||
``` | ||
|
||
_Note: A simple tool to validate `geographies.json` will be contributed to the Open Mobility Foundation._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this note be included now? How close to being ready is this tool? It may take some time to contribute to a tool to the OMF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should discuss. I don't have a good answer. Perhaps it's trivial now that @thekaveman made a schema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just cut it for now so we can get this into the feature branch in OMF. The schema helps, and I'm not sure what this simple tool would be otherwise.
@@ -0,0 +1,150 @@ | |||
# Mobility Data Specification: Geography | |||
|
|||
This specification contains a collection of RESTful APIs used to read Geographies (descriptions of geographical information, e.g. multi-polygons, currently represented via GeoJSON). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are geographies always single or multi polygons? They will never be a line or point right? Either way we should clarify this somewhere in the spec. For an example, #480 assumes only polygons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FeatureCollection
is the highest-level concept. You can include lines and points but they are no-ops because they can't contain points. We will revisit once we have a curb spec.
@@ -31,6 +31,8 @@ The Mobility Data Specification (**MDS**), a project of the [Open Mobility Found | |||
|
|||
* The [`policy`][policy] API endpoints are intended to be implemented by regulatory agencies and consumed by mobility providers. Providers query the Policy API to get information about local rules that may affect the operation of their mobility service or which may be used to determine compliance. It was first released in October 2019. Development takes place under the guidance of the OMF's City Services Working Group. | |||
|
|||
* The [`geography`][geography] API endpoints are intended to be implemented by regulatory agencies and consumed by mobility providers. Providers query the Policy API to get information about geographical regions for regulatory and other purposes. It was first released in October 2019, originally included as part of the Policy specification. Development takes place under the guidance of the OMF's City Services Working Group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new endpoint, the title line should now be "MDS is currently comprised of four distinct components"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Good catch. Fixed.
Merging this to the feature branch so we can look at it holistically, make edits and suggestions, and incorporate other related issues/PRs before we agree on the spec and merge to dev. |
PR #499 is merged to a 'feature branch' in the MDS repo so we can see how it fits into the larger spec, allow the community and staff to do PRs against it, merge other related PRs into it, and see how it will fit into dev when it's ready with PR #582. See the 'feature-geography' branch for details. |
Originally the Policy API included the Geography API, because Policy needed Geography objects.
As other proposed services (e.g. Jurisdiction API) are introduced, Geography really should be its own thing.
UPDATE
PR #499 is merged to a 'feature branch' in the MDS repo so we can see how it fits into the larger spec, allow the community and staff to do PRs against it, merge other related PRs into it, and see how it will fit into dev when it's ready with PR #582.
See the 'feature-geography' branch for details.