Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination fix. Fixes #20 #35

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Pagination fix. Fixes #20 #35

merged 1 commit into from
Aug 22, 2018

Conversation

hunterowens
Copy link
Collaborator

We suggest that you JSON API but don't explicitly call out how to do pagination. This creates a root level document, meta.md to handle all pagination, auth and other info applicable to provider and agency.

@hunterowens hunterowens mentioned this pull request Aug 21, 2018
Merged
toddapetersen
toddapetersen approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@toddapetersen toddapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My experience is limited in this area, I'll defer to Hunter on what is best practice.

@hunterowens hunterowens merged commit 8a5ea50 into master Aug 22, 2018
@hunterowens hunterowens deleted the pagination-meta branch August 24, 2018 15:01
@tonial tonial mentioned this pull request Mar 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddapetersen toddapetersen toddapetersen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hunterowens @toddapetersen