Consistency in underscores #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just switched to deregister vehicle, since that change was merged in #31 Personally, I don't think it makes sense to have the header be "deregister" when the endpoint is "remove" though |
|
I'm used to dashes, but I also used to write stuff in Django so maybe that's why. Requesting @toddapetersen to review |
|
@sethherr we're gonna go ahead and use underscores. We've made the appropriate changes in the provider spec, however, Agency is still behind. Would you mind rebasing and pushing that to us and we can merge in? |
|
Should be fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to have all the responses use snake case (underscores) with endpoints with dashes.
Partially because consistency but also because most web frameworks use underscores. The only one I'm aware of that uses dashes is Django, and that seems somewhat contentious