Initial check in of issue and PR templates #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2019
hunterowens
approved these changes
Apr 3, 2019
|
@jfh01 this LGTM, should we merge? |
|
I'd like @ccolgrove to review re: language around breaking vs. non-breaking. Also, I want to update CONTRIBUTING and ReleaseGuidelines to reflect this. I'll update the PR later today. |
ccolgrove
reviewed
Apr 5, 2019
|
@hunterowens I tweaked the language slightly per @ccolgrove's comments and updated ReleaseGuidelines.md to reflect the Milestone tagging process (something we need to apply to this PR!). Ready to merge. |
hunterowens
approved these changes
Apr 9, 2019
hunterowens
approved these changes
Apr 9, 2019
rf-
added a commit
to remix/mobility-data-specification
that referenced
this pull request
Apr 16, 2019
This commit adds a section to the release guidelines doc clarifying the distinction between breaking and non-breaking changes, including an enumeration of what kinds of changes fall in each category. This builds on language added in openmobilityfoundation#286; I didn't modify those templates here since their description of breaking vs. non-breaking is still accurate. I think the most likely area of controversy here is the handling of enum values. My inclination would actually be to treat changes to enum values as breaking changes, but it seems like the consensus during the 0.3.1 process so far has been that the benefits of having a lightweight process for updating enums outweigh the risk of breaking clients that are doing stricter validations. Fixes openmobilityfoundation#279
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on #270, this will help ensure that maintainers have the right information to tag issues and PRs with the correct milestones and labels. The information supplied about breaking/non-breaking changes will also be used to determine which release a given change should be targeted for.