Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add new battery_charged event type reason" #254

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

marie-x
Copy link
Collaborator

@marie-x marie-x commented Feb 26, 2019

Reverts #237

@marie-x marie-x requested a review from hunterowens February 26, 2019 17:44
@hunterowens hunterowens merged commit 04e927a into dev Feb 26, 2019
@hunterowens hunterowens deleted the revert-237-bluesystems/battery_charged branch February 28, 2019 00:48
@hunterowens hunterowens added this to the 0.3.1 milestone Apr 29, 2019
@Retzoh
Copy link
Contributor

Retzoh commented Jan 21, 2020

Hi @Karcass , sorry for returning to this PR later on but why was the battery_charged transition removed? It actually makes a lot of sense in the carsharing context.

@marie-x
Copy link
Collaborator Author

marie-x commented Jan 21, 2020

I don't recall. I think @hunterowens had some concern about it. Probably should have written that reasoning down! I'd be fine with re-adding battery_charged as a transition from unavailable to available.

@thekaveman
Copy link
Collaborator

I think at least some of the reasoning was related to how it wasn't totally clear how new modes (specifically carshare) are represented in MDS. I think we have a better idea now after #336.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants