Agency schema redux #238
Merged
Agency schema redux #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Apologies to keep moving the goalposts @ian-r-rose, but there's another round of changes that make this PR obsolete. I think we might push this to 0.3.2? We'd really like to cut 0.3.1 soon. |
ian-r-rose
force-pushed
the
agency-schema-redux
branch
from
b476d15 to
10a5c62
Compare
Note: the initial status of a vehicle during and event update is prescribed, but not enforced, to allow for asynchronous processing of updates.
ian-r-rose
force-pushed
the
agency-schema-redux
branch
from
10a5c62 to
c1740a5
Compare
|
Updated in light of #258, #249, #245. The API is getting rich enough that it's probably time to investigate using OpenAPI rather than pure JSONSchema to better document the responses that are possible from the Agency API. However, I think that's a big enough undertaking that it may be better for a follow-up. |
|
Looks good to me. Would like eyeballs on from @hunterowens and @toddapetersen. |
thekaveman
added
Agency
|
@Karcass this looks good to me. I can clean up, rebase and merge in? |
hunterowens
approved these changes
May 10, 2019
|
@hunterowens yep! |
marie-x
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169.
Supersedes #172.
I have tried to follow the current
agency/README.mdindevas closely as possible. If there are existing open PRs which I should also try to take into account, feel free to let me know.Also, this is not particularly well-tested in the absence of synthetic agency data, so there are likely some issues that will need to be ironed out, here or in follow-ups.