Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Routes Implementation. fixes #19 #21

Merged
merged 1 commit into from
Aug 9, 2018
Merged

New Routes Implementation. fixes #19 #21

merged 1 commit into from
Aug 9, 2018

Conversation

hunterowens
Copy link
Collaborator

This change replaces start_point, end_point and associated field with routes, a new datatype which is a geojson list of points to represent the route a device took during a trip.

@hunterowens
Copy link
Collaborator Author

@dmklinger @thekaveman does this meet your needs?

@thekaveman
Copy link
Collaborator

This leaves start_time and end_time as part of the Trip structure, where we assume this data would also be captured as part of the first/last points in the new Route object, correct?

In #19, @dmklinger suggests removing these time fields. I can see the benefit of not having to dive into the geoJSON to get these two values, but they may be duplicative. Were they intentionally left as part of the Trip object? Perhaps these represent when the vehicle was locked/unlocked by the user, vs. when the vehicle actually started moving?

@hunterowens
Copy link
Collaborator Author

@thekaveman / @dmklinger do we have resolution on this?

Copy link
Contributor

@dmklinger dmklinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@hunterowens hunterowens merged commit 8e842db into master Aug 9, 2018
@hunterowens hunterowens deleted the routes branch August 9, 2018 21:14
schnuerle pushed a commit that referenced this pull request Apr 28, 2022
…ed-and-recommissioned-events

Add decommissioned and recommissioned events for Taxi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants