Skip to content

Commit

Permalink
Allow any status change to include an associated_trip
Browse files Browse the repository at this point in the history
PR #297 already updated the spec language to make it clear that any
status change is allowed to have an `associated_trip`, but I didn't
realize this was incompatible with the existing schema. The schema
should now match the spec, which states that `user_pick_up` and
`user_drop_off` events must have an `associated_trip` but other events
may have one when applicable.
  • Loading branch information
rf- authored and hunterowens committed Oct 1, 2019
1 parent 3ec99ad commit 8e4a297
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion provider/dockless/status_changes.json
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@
},
{
"description": "conditionally require associated_trip when applicable",
"oneOf": [
"anyOf": [
{
"not": {
"properties": {
Expand Down
2 changes: 1 addition & 1 deletion schema/templates/provider/status_changes.json
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@
},
{
"description": "conditionally require associated_trip when applicable",
"oneOf": [
"anyOf": [
{
"not": {
"properties": {
Expand Down

0 comments on commit 8e4a297

Please sign in to comment.