Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backtrace an optional feature #1602

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Make backtrace an optional feature #1602

merged 2 commits into from
Jul 3, 2024

Conversation

keks
Copy link
Contributor

@keks keks commented Jul 2, 2024

This PR makes backtrace an optional feature in order to make the library faster in non-debug builds.

fixes #1598

@keks keks requested a review from franziskuskiefer July 2, 2024 12:15
@keks keks requested a review from a team as a code owner July 2, 2024 12:15
@github-actions github-actions bot added the size/s label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.77%. Comparing base (2f835f7) to head (42e35d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1602   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files         186      186           
  Lines       21357    21358    +1     
=======================================
+ Hits        18105    18106    +1     
  Misses       3252     3252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keks keks merged commit 58df3c7 into main Jul 3, 2024
54 checks passed
@keks keks deleted the keks/optional-backtrace-dep branch July 3, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Don't enable backtrace feature by default
2 participants