Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cipher suite and version from Secret #1545

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

raphaelrobert
Copy link
Member

Fixes #1511.

This PR removes the ciphersuite and protocol version from the Secret struct:

pub(crate) struct Secret {
    pub(in crate::ciphersuite) ciphersuite: Ciphersuite,
    pub(in crate::ciphersuite) value: SecretVLBytes,
    pub(in crate::ciphersuite) mls_version: ProtocolVersion,
}

pub(crate) struct Secret {
    pub(in crate::ciphersuite) value: SecretVLBytes,
}

To make the review easy, this is the only change. The rest of the PR is churn. There's quite a bit of it, since the secrets were used to carry the ciphersuite which now has to be passed manually. Conversely, the protocol version no longer has to passed in quite a few functions.

@raphaelrobert raphaelrobert requested a review from a team as a code owner April 4, 2024 10:13
@raphaelrobert raphaelrobert self-assigned this Apr 4, 2024
@github-actions github-actions bot added the size/l label Apr 4, 2024
Copy link
Member

@kkohbrok kkohbrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with one nit.

openmls/src/ciphersuite/tests/test_secrets.rs Outdated Show resolved Hide resolved
@raphaelrobert raphaelrobert requested a review from kkohbrok April 4, 2024 10:54
@raphaelrobert raphaelrobert merged commit 033f4e6 into main Apr 4, 2024
51 checks passed
@raphaelrobert raphaelrobert deleted the raphael/lean-secrets branch April 4, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove cipher suite and version from Secret
2 participants