Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add diff util #1540

Merged
merged 1 commit into from
Sep 20, 2024
Merged

feat: add diff util #1540

merged 1 commit into from
Sep 20, 2024

Conversation

chrisgacsal
Copy link
Contributor

Overview

Add a simple helper for calculating the difference between two slices.

@chrisgacsal chrisgacsal self-assigned this Sep 19, 2024
@chrisgacsal chrisgacsal mentioned this pull request Sep 19, 2024
@chrisgacsal chrisgacsal added the release-note/misc Miscellaneous changes label Sep 19, 2024
pkg/diff/diff.go Outdated

import "github.com/samber/lo"

type Diff[T comparable, S ~[]T] struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be moved to slicesx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@turip turip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@chrisgacsal chrisgacsal merged commit 95a51ef into main Sep 20, 2024
18 checks passed
@chrisgacsal chrisgacsal deleted the diff-util branch September 20, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc Miscellaneous changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants