Add entitlements APIs and resources to TypeSpec #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GAlexIHU
changed the title
GAlexIHU
force-pushed
the
feat/entitlements-typespec
branch
from
794381d
to
12ff45e
Compare
tothandras
previously requested changes
Sep 19, 2024
GAlexIHU
commented
Sep 20, 2024
tothandras
force-pushed
the
feat/entitlements-typespec
branch
2 times, most recently
from
84e9c50
to
cedebfe
Compare
GAlexIHU
force-pushed
the
feat/entitlements-typespec
branch
from
cedebfe
to
3d58c41
Compare
There was a problem hiding this comment.
A general comment on naming:
- EntitlementCreateInputs -> CreateEntitlementRequest (or NewEntitlement)
- EntitlementStatic -> StaticEntitlement
These names feel more natural to me.
While I realize these are breaking changes for OpenAPI, due to friendly name we can make these changes in TypeSpec. (Can be delayed, but please create a task somewhere)
It would be interesting to see if we can use TypeSpec for better server side code generation.
sagikazarmark
approved these changes
Sep 20, 2024
feat: write entitlement types and base endpoints feat: add management apis chore: address PR comments chore(api): entitlements nits
GAlexIHU
force-pushed
the
feat/entitlements-typespec
branch
from
a3c8e6a
to
2180a84
Compare
sagikazarmark
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements the entitlements related APIs in TypeSpec
Notes for reviewer
TypeSpec doesn't cover 100% of OAPI3 which results in some differences in the generated output.
allOftypes so thelastResetprop ongetEntitlement's return value isn't on top level anymore