Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(migrate): use initialized pgx driver #1473

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor(migrate): use initialized pgx driver #1473

wants to merge 4 commits into from

Conversation

GAlexIHU
Copy link
Contributor

@GAlexIHU GAlexIHU commented Sep 4, 2024

Overview

Use the pgx sql.DB instance for migrations tooling

Fixes #1470

Notes for reviewer

@GAlexIHU GAlexIHU added the release-note/misc Miscellaneous changes label Sep 4, 2024
@chrisgacsal
Copy link
Contributor

Some tests are failing, otherwise it looks good to me.

@sagikazarmark
Copy link
Member

Blocked by golang-migrate/migrate#1156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagikazarmark sagikazarmark sagikazarmark left review comments

@hekike hekike Awaiting requested review from hekike

@chrisgacsal chrisgacsal Awaiting requested review from chrisgacsal

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release-note/misc Miscellaneous changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use initialized PGX driver in migrations
3 participants
@GAlexIHU @chrisgacsal @sagikazarmark