Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: metrics #1442

Merged
merged 5 commits into from
Aug 29, 2024
Merged

refactor: metrics #1442

merged 5 commits into from
Aug 29, 2024

Conversation

turip
Copy link
Contributor

@turip turip commented Aug 29, 2024

Overview

This patch improves the consistency/data available in consumer metrics. Changes:

  • refactor: use int64 histograms (better for datadog, float64 ones are not working properly)
  • refactor: add group handler metrics (So that we can report the skipped/ignored messages too.)
  • refactor: unify router metrics (so that they are better aligned with the previous one)
  • refactor: rename sarama metrics (Previously it was sarama.publisher.publisher / sarama.publisher.subscriber, now the redundant publisher part is dropped)
  • refactor: use namespaces (e.g. watermill.router. for metrics, for easier debugging)

They are working better with datadog.
So that we can report the skipped/ignored messages too.
Previously it was sarama.publisher.publisher / sarama.publisher.subscriber
now the redundant publisher part is dropped.
@turip turip added the release-note/misc Miscellaneous changes label Aug 29, 2024
@turip turip marked this pull request as ready for review August 29, 2024 09:04
@turip turip changed the title Refactor/metrics refactor: metrics Aug 29, 2024
@turip turip merged commit 492686a into main Aug 29, 2024
17 of 18 checks passed
@turip turip deleted the refactor/metrics branch August 29, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc Miscellaneous changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants