Correct openmc.Geometry initializer to accept iterables of openmc.Cell #3081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #3079, it was pointed out that the
openmc.Geometry
constructor should accept an optional object of eitheropenmc.Universe
orIterable[openmc.Cell]
, but was coded only to accept the former.Quick Fix
With PEP 604, we can change
Optional[type] = None
to the no-strings-attached alternate formtype | None = None
made available in Python 3.10+. Since|
is also another way to expresstyping.Union[]
, it's easy enough to add the other needed case foropenmc.Geometry
.In any case, in the rest of the codebase, the
Optional[type]
syntax appears 163 more times. It shouldn't be too difficult to refactor all of that intotype | None = None
for conciseness and readability, though that's probably for a different PR.Checklist