Determine whether nuclides are fissionable in volume calc mode #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
requested changes
Jun 19, 2024
There was a problem hiding this comment.
Tiny suggestion here and then I think this should be good. Thanks @paulromano!
Co-authored-by: Patrick Shriwise <[email protected]>
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
…c-dev#3047) Co-authored-by: Patrick Shriwise <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a potential issue in sampling external source sites when OpenMC is loaded in volume calculation mode (which is used by the plotter). When running in volume calculation mode, we only load a select few attributes from nuclide .h5 files. Right now, we don't determine whether a nuclide is fissionable. However, for a proposed improvement to our plotter (see openmc-dev/plotter#131), it will be possible to sampling external source sites, which may require information on whether a material is fissionable if the "fissionable only" constraint is applied to the source. Without that information, a source with the "fissionable only" constraint will always be rejected because it won't think any material is fissionable (because the underlying nuclides aren't fissionable). This branch adds a small block of logic to determine if a nuclide is fissionable when it is loaded in volume calculation mode.
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)