Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IsogonalOctagon to use xz basis and update tests #3045

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

ybadr16
Copy link
Contributor

@ybadr16 ybadr16 commented Jun 18, 2024

Description

Switched the zx basis for IsogonalOctagon to xz by following a similar strategy done to CylindricalSectors in #3018, updated the corresponding unit test so the second parameter matches the changes.

Fixes #3019

Checklist

  • [ ✅] I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • [✅] I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • [✅] I have added tests that prove my fix is effective or that my feature works (if applicable)

@paulromano paulromano added this to the v0.15.0 milestone Jun 18, 2024
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ybadr16!

@paulromano paulromano enabled auto-merge (squash) June 18, 2024 21:05
@paulromano paulromano merged commit f6d3ee7 into openmc-dev:develop Jun 18, 2024
15 checks passed
@ybadr16 ybadr16 deleted the fix branch June 21, 2024 12:22
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make IsogonalOctagon objects parallel to y axis use xz basis.
2 participants