Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve warnings related to numpy 2.0 #3044

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

paulromano
Copy link
Contributor

Description

Now that NumPy 2.0 has been released, I'm noticing a few more warnings about deprecations in our CI test output. This PR gets rid of these warnings.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@paulromano paulromano requested a review from nelsonag as a code owner June 18, 2024 20:34
@paulromano paulromano added this to the v0.15.0 milestone Jun 18, 2024
@paulromano paulromano requested a review from pshriwise June 19, 2024 00:47
@paulromano
Copy link
Contributor Author

To elaborate on the change with integrate(...), that is a local variable that points to scipy.integrate.simpson, where as of the latest release of SciPy the function signature now expects the x's to be passed as a keyword-only argument.

Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for staying ahead of the NumPy update @paulromano!

@pshriwise pshriwise merged commit 3dff03f into openmc-dev:develop Jun 19, 2024
16 checks passed
@paulromano paulromano deleted the more-numpy-2.0-fixes branch June 20, 2024 14:27
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants