Make sure direction is set when checking source spatial constraints #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
approved these changes
Jun 3, 2024
|
Will merge at EOB if there are no other concerns. |
|
It's a sensical one-liner. Going to go ahead w this one... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When #2916 refactored how source constraints are handled, it looks like a bug was introduced for checking spatial constraints. Namely, a
GeomStateobject is created and the position is set, but the direction was not set (see here for the previous code). I noticed recently when running a DAGMC geometry that this was resulting in the source being rejected when it shouldn't have been. This PR fixes this by setting an arbitrary direction on theGeomStateobject as we did before.Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)