Update random_dist.h comment to be less specific #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe this should be closed because these are indeed only used for sampling fission energies? I'm not aware of what nuclides just use a normal distribution for fission energies. I dunno, OpenMC is pretty useful as a general C++ library to link to, so when I was checking the docs to use this in some other C++ code I had to double-check this isn't something different from a plain old Gaussian. |
paulromano
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment describing our normal distribution sampling routine for some reason calls it the "Gaussian fisison energy distribution". This PR clarifies the comment so as to not confuse people; there is nothing intrinsically related to fission here.