Correction for histogram interpolation of Tabular distributions #2981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
openmc.stats.Tabular
class assumes that the length of the probabilities provided is equal to the length of the table values. This causes errors when one passes N -1 probabilities for N table values in histogram interpolationbecause we index into the probabilities as
[:-1]
. This changes that index based on the size of the table values.Several warnings have also been added in the
Tabular.p
property setter to check its length against the size of the table values (if they are set).Checklist
- [ ] I have run clang-format (version 15) on any C++ source files (if applicable)- [ ] I have made corresponding changes to the documentation (if applicable)