Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bounding_box docstrings #2972

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

paulromano
Copy link
Contributor

Description

Simple PR here updating some docstrings related bounding boxes and also using BoundingBox.infinite() in one place.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@paulromano paulromano requested a review from shimwell April 23, 2024 16:25
Copy link
Member

@shimwell shimwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Feel free to merge or I shall merge tomorrow if there are not objections

@shimwell shimwell added the Merging Soon PR will be merged in < 24 hrs if no further comments are made. label Apr 24, 2024
Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @paulromano!

@pshriwise
Copy link
Contributor

Looks good to me. Feel free to merge or I shall merge tomorrow if there are not objections

No objections here :)

@pshriwise pshriwise merged commit b54b1e9 into openmc-dev:develop Apr 24, 2024
18 checks passed
@paulromano paulromano deleted the bbox-docfix branch April 24, 2024 14:09
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merging Soon PR will be merged in < 24 hrs if no further comments are made.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants