moved apt get to optional ci parts #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimwell
commented
Apr 21, 2024
shimwell
commented
Apr 21, 2024
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
Co-authored-by: Paul Romano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This helps make the tools/ci scripts more operating system agonistic by moving the only ubuntu specific command (
apt-get) from thegha-install-vectfit.shscript. In the future we may want to run this sh script on mac os or another linux os which doesn't have access to apt get so it would be useful to remove this park of the sh script. Now theapt-getcommand is in the CI where all the otherapt-getcommands are locatedWhile adding the conditional section to the CI runner I noticed that we do apt-get install of many packages for all of the matrix combinations. I split out the mpi related one as and set them to run only if mpi is requested on the matrix. This should save a small amount of CI time for these runs.
Fixes # (issue)
not an issue but working towards getting the ci running on mac
Checklist