Update minimum Python version to 3.8 #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Unrelated to the original changes in this PR, the pip install of mpi4py broke due to a new version of setuptools (see mpi4py/mpi4py#484). I put a workaround in this PR that hopefully gets us back to a green check mark 🤞 |
5 tasks
|
I think setuptools 69.4.0 and 69.3.0 have just been yanked from pypi https://pypi.org/project/setuptools/#history |
shimwell
reviewed
Apr 13, 2024
shimwell
approved these changes
Apr 15, 2024
|
Looks good, feel free to merge. If not I will merge tomorrow. |
shimwell
added
the
Merging Soon
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates our minimum Python version to 3.8 since 3.7 is already past EOL. For CI configurations, I've replaced 3.7 with a new configuration for 3.12 so that it is tested.
Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)I have followed the style guidelines for Python source files (if applicable)